leonardBang commented on a change in pull request #13708:
URL: https://github.com/apache/flink/pull/13708#discussion_r508971859
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/join/TemporalJoinTest.xml
##########
@@ -43,13 +43,13 @@ Calc(select=[amount, currency, rowtime,
PROCTIME_MATERIALIZE(proctime) AS procti
:- Exchange(distribution=[hash[currency]])
: +- WatermarkAssigner(rowtime=[rowtime], watermark=[rowtime])
: +- Calc(select=[amount, currency, rowtime, PROCTIME() AS proctime])
- : +- LegacyTableSourceScan(table=[[default_catalog,
default_database, Orders, source: [CollectionTableSource(amount, currency,
rowtime)]]], fields=[amount, currency, rowtime])
+ : +- TableSourceScan(table=[[default_catalog, default_database,
Orders]], fields=[amount, currency, rowtime])
+- Exchange(distribution=[hash[currency]])
+- Calc(select=[currency, rate, rowtime], where=[<(rate, 100)])
+- Rank(strategy=[AppendFastStrategy], rankType=[ROW_NUMBER],
rankRange=[rankStart=1, rankEnd=1], partitionBy=[currency], orderBy=[rowtime
DESC], select=[currency, rate, rowtime])
+- Exchange(distribution=[hash[currency]])
+- WatermarkAssigner(rowtime=[rowtime], watermark=[rowtime])
- +- LegacyTableSourceScan(table=[[default_catalog,
default_database, RatesHistory, source: [CollectionTableSource(currency, rate,
rowtime)]]], fields=[currency, rate, rowtime])
+ +- TableSourceScan(table=[[default_catalog,
default_database, RatesHistory]], fields=[currency, rate, rowtime])
Review comment:
Could we add one `Collection` test to ensure the temporal join plan
works fine with Legacy connector?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
