XComp commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-713382349
> @XComp I was able to identify the code fix. I working to unit test it had
some issue with Flink set up to start a job with checkpoint and savepoint. it
might take a day or so as I am doing it for the first time.
Hi @gm7y8 , thanks for getting back to us. Let's see if we can finish this
before the codefreeze next week. Here a few remarks:
* The build is failing for me locally (`mvn -pl flink-runtime-web -Dfast
-DskipTests install`) with the following error message:
```
[ERROR] ERROR in
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Element implicitly has an 'any' type because type
'CheckPointDetailInterface' has no index signature.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Property 'checkpoint_type' does not exist on type
'JobCheckpointsDetailComponent'.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Property 'checkPointConfig' does not exist on type
'JobCheckpointsDetailComponent'.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Element implicitly has an 'any' type because type
'CheckPointDetailInterface' has no index signature.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Property 'checkpoint_type' does not exist on type
'JobCheckpointsDetailComponent'.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Element implicitly has an 'any' type because type
'CheckPointDetailInterface' has no index signature.
[ERROR]
src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html(25,38):
: Property 'checkpoint_type' does not exist on type
'JobCheckpointsDetailComponent'.
```
It's always good run a final `mvn install` at least on the modules you
touched to verify your changes. Alternatively (or rather as an additional
tool), you can setup Azure CI on your fork. That will run a full test covering
all modules for each commit on your fork. Check out the [tutorial for setting
up Azure
CI](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
* The changes like
[job-checkpoints-detail.component.html](https://github.com/apache/flink/pull/13458/commits/0b8e369aa5c8c4e4a8c370b4b848c0f197fcdb9d#diff-a1c50fd814fe8a1c03567f9c71877873251223cfaf32c7067068f7f30d8c5c42R25)
does not reflect @AHeise's request as you use uppercased tokens here. @AHeise
suggested normal casing (i.e. lowercase) as it helps to improve the readability.
* Additionally, I realized that you didn't address all points of the PR
description template. May you fix that?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
