tillrohrmann commented on a change in pull request #13725:
URL: https://github.com/apache/flink/pull/13725#discussion_r509929799
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalService.java
##########
@@ -170,7 +174,6 @@ public void nodeChanged() throws Exception {
notifyIfNewLeaderAddress(leaderAddress,
leaderSessionID);
} catch (Exception e) {
leaderListener.handleError(new
Exception("Could not handle node changed event.", e));
- throw e;
Review comment:
Yes, that is the reasoning. The `leaderListener.handleError` should
handle all exceptions and usually terminate the process. But let me actually
add `ExceptionUtils.checkInterrupted(e);` here again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
