[
https://issues.apache.org/jira/browse/FLINK-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218821#comment-17218821
]
xiaogang zhou edited comment on FLINK-19757 at 10/22/20, 7:30 AM:
------------------------------------------------------------------
Hi [~jark] ， My point is using LocalDateTime to represent the
TIMESTAMP(TIMESTAMP WO LOCAL TIME ZONE ) is not very proper :)
as the ofEpochSecond takes a offset and the toString method return a local
time. Should we consider it more proper as a TIMESTAMP WITH LOCAL TIME ZONE?
And in 1.11 , user defined sink/ user defined source is supported, so I think
the TimeStampData is not completely "internal".
TimestampLocalDateTimeConverter just returns the LocalDateTime, this is pretty
hard to control which timezone i will get in a sink. it is much easier if we
consider the timezone problem when convert to the LocalDateTime
was (Author: zhoujira86):
Hi [~jark] ， My point is using LocalDateTime to represent the
TIMESTAMP(TIMESTAMP WO LOCAL TIME ZONE ) is not very proper :)
as the ofEpochSecond takes a offset and the toString method return a local
time. Should we consider it more proper as a TIMESTAMP WITH LOCAL TIME ZONE?
> TimeStampData can cause time inconsistent problem
> -------------------------------------------------
>
> Key: FLINK-19757
> URL: https://issues.apache.org/jira/browse/FLINK-19757
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
> Affects Versions: 1.11.1
> Reporter: xiaogang zhou
> Priority: Major
> Labels: pull-request-available
>
> when we check jdk LocalDateTime code，we find that
>
> {code:java}
> // code placeholder
> public static LocalDateTime ofEpochSecond(long epochSecond, int nanoOfSecond,
> ZoneOffset offset) {
> Objects.requireNonNull(offset, "offset");
> NANO_OF_SECOND.checkValidValue(nanoOfSecond);
> long localSecond = epochSecond + offset.getTotalSeconds(); // overflow
> caught later
> long localEpochDay = Math.floorDiv(localSecond, SECONDS_PER_DAY);
> int secsOfDay = (int)Math.floorMod(localSecond, SECONDS_PER_DAY);
> LocalDate date = LocalDate.ofEpochDay(localEpochDay);
> LocalTime time = LocalTime.ofNanoOfDay(secsOfDay * NANOS_PER_SECOND +
> nanoOfSecond);
> return new LocalDateTime(date, time);
> }
> {code}
>
> offset.getTotalSeconds() they add the offset, but in the TimeStampData
> toLocalDateTime, we don't add a offset.
>
> I'd like to add a TimeZone.getDefault().getRawOffset() in the
> toLocalDateTime()
> and minus a TimeZone.getDefault().getRawOffset() in the
> fromLocalDateTime
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
