vthinkxie commented on a change in pull request #13458:
URL: https://github.com/apache/flink/pull/13458#discussion_r509948888
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html
##########
@@ -21,6 +21,8 @@
<strong>Path:</strong> {{checkPointDetail?.external_path || '-'}}
<nz-divider nzType="vertical"></nz-divider>
<strong>Discarded:</strong> {{checkPointDetail?.discarded || '-'}}
+ <nz-divider nzType="vertical"></nz-divider>
+ <strong>Checkpoint Type:</strong> {{checkPointDetail?.checkpoint_type ===
"CHECKPOINT" ? (checkPointConfig?.unaligned_checkpoints ? 'unaligned
checkpoint' : 'aligned checkpoint') : (checkPointDetail?.checkpoint_type ===
"SYNC_SAVEPOINT" ? 'savepoint on cancel' : 'savepoint')|| '-'}}
Review comment:
Hi @gm7y8
it would be better to move this calculation into the typescript file as a
getter, and binding the getter here, since the calculation is a little too
complex for the template file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
