JingsongLi commented on a change in pull request #13729:
URL: https://github.com/apache/flink/pull/13729#discussion_r510028759



##########
File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveLookupFunction.java
##########
@@ -134,9 +188,48 @@ public void eval(Object... values) {
                }
        }
 
-       @VisibleForTesting
-       public Duration getCacheTTL() {
-               return cacheTTL;
+       private HiveTableInputFormat getHiveTableInputFormat() {

Review comment:
       Can we add a `copy(Partitions)` method to `HiveTableInputFormat`? Then 
we don't need move so many logicals.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to