twalthr commented on a change in pull request #13732:
URL: https://github.com/apache/flink/pull/13732#discussion_r510144202
##########
File path: flink-core/src/main/java/org/apache/flink/types/Row.java
##########
@@ -274,4 +278,119 @@ public static Row join(Row first, Row... remainings) {
return joinedRow;
}
+
+ /**
+ * Compares two {@link Row}s for deep equality. This method supports
all conversion classes of the
+ * table ecosystem.
+ *
+ * <p>The current implementation of {@link Row#equals(Object)} is not
able to compare all deeply
+ * nested row structures that might be created in the table ecosystem.
For example, it does not
+ * support comparing arrays stored in the values of a map. We might
update the {@link #equals(Object)}
Review comment:
I might not understand your comment here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
