wuchong commented on a change in pull request #13694:
URL: https://github.com/apache/flink/pull/13694#discussion_r510768230
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java
##########
@@ -24,16 +24,16 @@
import org.apache.flink.table.data.RowData;
/**
- * Provider to consume a {@link DataStream} as a runtime implementation for
- * {@link DynamicTableSink}.
+ * Provider that consumes a Java {@link DataStream} as a runtime
implementation for {@link DynamicTableSink}.
*
- * <p>NOTE: This is only for advanced connector developers.
+ * <p>Note: This provider is only meant for advanced connector developers.
Usually, a sink should consist
+ * of a single entity expressed via {@link OutputFormatProvider} or {@link
SinkFunctionProvider}.
Review comment:
+1 for this. This makes the responsibility of this interface more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
