wangyang0918 commented on pull request #13644: URL: https://github.com/apache/flink/pull/13644#issuecomment-715290752
@tillrohrmann Thanks for the discussion and review. I have addressed all the comments you have left and force pushed. The PR get bigger, but I think it is more clear. The biggest changes are listed as following. * Use composition instead of inheritance for `LeaderElectionService` and `LeaderRetrievalService`. Now it is easier to add new implementation of the both services. * The `HaServices` abstraction is still using inheritance since it is easy enough to add new implementation. And we could not get too much benefit using composition. * When ConfigMap is deleted/updated externally, we will throw error instead of handling internally. * Add ITCases for the new introduced leader election/retrieval services Maybe @xintongsong could also have another look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
