StephanEwen commented on pull request #13637:
URL: https://github.com/apache/flink/pull/13637#issuecomment-715338013
A few more comments on this:
- `@Experimental` annotations should not just be added lightly. If we
deprecate one method (`generateSequence()`) then the replacement for that
should not be experimental, because that leaves users wondering what they
should use then.
- The Scala API should her not be tested with a test that executed the
program. That is not very targeted testing. The Scala API only wraps the
source, which can be tested in a much more lightweight way. Anything that an
execution-based test verifies is relevant to the main source, not the Scala
wrapper.
I am a bit unsure how we want to do watermarks in the `fromSequence()` case.
Should we have no watermarks by default? I think we should at least have an
option that supports adding timestamps/watermarks.
@aljoscha what is your take here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
