JingsongLi commented on a change in pull request #13636:
URL: https://github.com/apache/flink/pull/13636#discussion_r510930456
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -210,19 +212,35 @@ private boolean isStreamingSource() {
" cannot be
less than 1");
}
- int splitNum;
try {
- long nano1 = System.nanoTime();
- splitNum =
inputFormat.createInputSplits(0).length;
- long nano2 = System.nanoTime();
+ // `createInputSplits` is costly,
Review comment:
Yes, it can be a separate PR.
You are making the logic more complex, so I think you should cleanup code
first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
