StephanEwen edited a comment on pull request #13574:
URL: https://github.com/apache/flink/pull/13574#issuecomment-715423024
First of all, want to say nice work, this is a big piece after all! 👍
The first thing that struck me is that I believe we need to rethink the
Maven Module setup here:
The `flink-connector-base` is not Scala-versioned (has no Scala version
suffix). Because of that it must not release any artifacts that have a
(transitive) Scala dependency. The module has no Scala dependency in compile
scope, so the main artifact is fine.
The module has a Scala dependency in test-scope, for the minicluster
(testutils). So far the connector base did not release a test-scope artifact.
Now there is a change that exports a test jar. We need to do hence one of
the two following changes:
- Either the module gets a Scala version suffix. That would be good to
avoid, because otherwise all connectors that depend on this need to be
Scala-versioned as well (and released multiple times).
- Or we don't have a test jar. If we want reusable testing frameworks, we
can put them into a separate module
(`flink-test-utils/flink-connector-testframework` or so). A connector can then
again depend on this testing framework in a specific scala version as long as
it does not export a test jar.
I know, it complicated :-( But that's the ugly reality of Scala
cross-versioning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
