AHeise commented on a change in pull request #13778:
URL: https://github.com/apache/flink/pull/13778#discussion_r511748513
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -61,15 +61,23 @@
@Test
public void testInterruptsNotCached() throws Exception {
- ConnectionID connectionId = new ConnectionID(new
InetSocketAddress(InetAddress.getLocalHost(), 8080), 0);
- try (AwaitingNettyClient nettyClient = new
AwaitingNettyClient()) {
+ final NettyTestUtil.NettyServerAndClient nettyServerAndClient =
createNettyServerAndClient();
+ ConnectionID connectionId = new ConnectionID(new
InetSocketAddress(
+
nettyServerAndClient.server().getConfig().getServerAddress(),
+
nettyServerAndClient.server().getConfig().getServerPort()),
+ 0);
+ try {
+ AwaitingNettyClient nettyClient = new
AwaitingNettyClient(nettyServerAndClient.client());
PartitionRequestClientFactory factory = new
PartitionRequestClientFactory(nettyClient, 0);
nettyClient.awaitForInterrupts = true;
connectAndInterrupt(factory, connectionId);
nettyClient.awaitForInterrupts = false;
factory.createPartitionRequestClient(connectionId);
+ } finally {
+ nettyServerAndClient.client().shutdown();
+ nettyServerAndClient.server().shutdown();
}
Review comment:
I like the try-with-resource approach more - it makes the code cleaner
and test easier to understand. But you'd have to move the `AutoCloseable` to
`NettyServerAndClient`, which is probably out of scope here. I also now fully
understand your argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
