SteNicholas commented on pull request #13637: URL: https://github.com/apache/flink/pull/13637#issuecomment-716376982
> A few more comments on this: > > * `@Experimental` annotations should not just be added lightly. If we deprecate one method (`generateSequence()`) then the replacement for that should not be experimental, because that leaves users wondering what they should use then. > * The Scala API should her not be tested with a test that executed the program. That is not very targeted testing. The Scala API only wraps the source, which can be tested in a much more lightweight way. Anything that an execution-based test verifies is relevant to the main source, not the Scala wrapper. > > I am a bit unsure how we want to do watermarks in the `fromSequence()` case. Should we have no watermarks by default? I think we should at least have an option that supports adding timestamps/watermarks. > @aljoscha what is your take here? @StephanEwen , thanks for your comments above mentioned. Previously I thought that `fromSequence()` should be consistent with `fromSource()` so that `fromSequence()` would be added with `@Experimental` annotations. I have followed up with the comments by removing the annotation and updated the Scala API test cases. Please review again if you are available. Sorry for trouble you again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
