aljoscha commented on pull request #13637: URL: https://github.com/apache/flink/pull/13637#issuecomment-716460271
Thanks for the heads up! Regarding operator naming, I think it's good to have the name in the method, we just need to decide on a position and be consistent with it. I personally would prefer `fromSource(name, other, stuff)` because it keeps the name closer to the beginning of the parameters, which will become easier to read when you extend naming to things like `map(name, function)`, where the function can be a lambda. But I'm fine with either position, i.e. name at the beginning or the end. I just want consistency. 😅 Regarding watermarks: I would not add an overloaded method that takes a watermark strategy. If users need that they can use `fromSource()` and I think if they need custom watermarking they probably can use that "lower level" method. What we could do is use the `Long` itself as the timestamp and use it for watermarks. I think that would be the only sensible basis for a timestamp/watermark that is deterministic. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
