wsry commented on pull request #13595: URL: https://github.com/apache/flink/pull/13595#issuecomment-716519500
> The updated logic looks good. But the name `maxBuffersPerSortMergePartition` seems confusing. I think we should rename this to `minBuffersPerSortMergePartition` and also rename the config key to `taskmanager.network.sort-shuffle.min-buffers`. > > What is a good default for the minimum number of buffers? Maybe something like 512? @StephanEwen These are good suggestions. `taskmanager.network.sort-shuffle.min-buffers` is easier to understand from the perspective of user and set the default value to 512 is also reasonable. I have updated the PR accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
