wangyang0918 edited a comment on pull request #13644: URL: https://github.com/apache/flink/pull/13644#issuecomment-716414850
@tillrohrmann I have address the comments you left and pushed again. Compared with previous PR, you could find the following changes. * Introduce `LeaderElectionEventHandler` and `LeaderRetrievalEventHandler`. They define the contracts between `LeaderElectionDriver`/`LeaderRetrievalDriver` and `DefaultLeaderElectionService`/`DefaultLeaderRetrievalService`. * Make some `ZooKeeperLeaderElection` tests could directly work with driver * Add test for `DefaultLeaderElectionService` * Use driver(not instantiate `DefaultLeaderElectionService`) for the HA unit tests. Then the tests are more purposeful. * Add ITCases for Kubernetes complicated test case, concurrent leader election, concurrent `checkAndUpdateConfigMap` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
