wuchong commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r512397979
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws
IOException {
}
}
+ @Override
Review comment:
Could you create an issue for this and add comment in the
`deserialize(byte[] message)` method?
I think the problem is that some connector doesn't migrate to
`deserialize(byte[] message, Collector<RowData> out)` yet, for example,
Kinesis. If we remove the implementation of `deserialize(byte[] message)`, the
upcoming Kinesis SQL connector will not support JSON format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
