SteNicholas commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512446648
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type)
{
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound,
Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
-
streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime)
{
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
@aljoscha I was worried about the other places make data stream with
processing time configuration but this handle all interval join operations of
data stream with event time at default. It's unreasonable that all join
operations are defaultly configured with event time and no validation about
this. What do you concern about that this don't allow configuring it for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
