SteNicholas edited a comment on pull request #13637:
URL: https://github.com/apache/flink/pull/13637#issuecomment-717119621
> Okay, lets add the name into the method. So basically have
`fromSequence("name", from to)`. That sounds good.
>
> @aljoscha and @SteNicholas the one worry I have about not adding a variant
with watermark strategy is that it cannot be used at all for streaming use
cases, because in the future we don't have the case any more where watermarks
are generated later in the stream.
>
> Maybe let's think how a `fromElements()` method would look like. Would it
have a WatermarkStrategy or not. I think that `fromSequence()` and
`fromElemets()` should be symmetric there.
@StephanEwen For the name into the `fromSequence(sourceName, from to)`, I
have followed your idea to update the name of the method.
About WatermarkStrategy, IMO, as you mentioned, I still stick to the point
that `fromSequence` and `fromElements()` method wouldn't have
WatermarkStrategy, because how big a difference between `fromSequence` and
`fromSource` if these methods have WatermarkStrategy? We could define
`fromSequence` that the method just simply creates data stream with sequence
and no watermark strategy.
@aljoscha , any idea for how a `fromElements()` method would look like and
would it have a WatermarkStrategy or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
