becketqin commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-717266246
Hi @StephanEwen , thanks for the comments. Re: the Scala versioning in the test-jar of `flink-connector-base`. Good catch! Having a separate module sounds a good approach. In terms of the close() method in `SplitEnumerator`, personally I prefer the generic `close()` helper as it provides a stronger guarantee on the component closure. I'll update the patch to add a `closeTimeoutHandler` to the `ComponentClosingUtils`. It can be used to fail the job after timeout. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
