kl0u commented on a change in pull request #13697:
URL: https://github.com/apache/flink/pull/13697#discussion_r512853491
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -251,14 +254,20 @@ T withBucketFactory(final BucketFactory<IN, BucketID>
factory) {
return self();
}
+ @Internal
+ @Override
Review comment:
@JingsongLi could you describe how this method is going to be used?
Because in this commit, it seems that it is a private method of the builder :)
Could it at least be package-private so that it is not exposed to the user?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
