zentol commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717821843
I'm still not a fan of automating the verification; people _will_ see the tool as the source of truth (which it isn't, as you pointed out), and any attempt at automating the generation can now be shut down with "well we have a tool to check the correctness, so let's not spend time on it". That said, it is obvious that it does find issues; particularly subtle ones that can _easily_ be missed during a manual review, `com` vs `org` is subtle AF and not really the focus of such a review (as it is more concerned with anything being listed at all and the version being correct). So I am, begrudgingly, fine with it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
