leonardBang commented on a change in pull request #13307:
URL: https://github.com/apache/flink/pull/13307#discussion_r513556517
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -294,6 +320,13 @@ private int indexOfFirstElementNewerThanTimer(long
timerTimestamp, List<RowData>
/**
* Binary search {@code rightRowsSorted} to find the latest right row
to join with {@code leftTime}.
* Latest means a right row with largest time that is still smaller or
equal to {@code leftTime}.
+ * For example with: rightState = [1(+I), 4(-U), 4(+U), 7(-U), 7(+U),
9(-D), 12(I)],
Review comment:
Got your point, maybe this performance improvement is minor because (1)
it only saves retraction records storage not all records (2) many retraction
records between two watermarks is not common, So I tend to improve it later if
it's very important for performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
