JingsongLi commented on a change in pull request #13789:
URL: https://github.com/apache/flink/pull/13789#discussion_r514077863
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -386,9 +394,11 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
boolean isInsertOnly =
helper.getOptions().get(SINK_INSERT_ONLY);
String runtimeSink = helper.getOptions().get(RUNTIME_SINK);
int expectedNum =
helper.getOptions().get(SINK_EXPECTED_MESSAGES_NUM);
+ Integer parallelism = helper.getOptions().get(SINK_PARALLELISM);
final Map<String, DataType> writableMetadata =
convertToMetadataMap(
helper.getOptions().get(WRITABLE_METADATA),
context.getClassLoader());
+ ChangelogMode changelogMode =
Optional.ofNullable(helper.getOptions().get(SINK_CHANGELOG_MODE_ENFORCED)).map(m
-> parseChangelogMode(m)).orElse(null);
Review comment:
This line is too long, you can break it.
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -929,10 +943,13 @@ public String asSummaryString() {
private DataType consumedDataType;
private int[] primaryKeyIndices;
private final String tableName;
- private final boolean isInsertOnly;
+ private final boolean
+ isInsertOnly;
Review comment:
Don't break line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
