zhuzhurk commented on a change in pull request #13641:
URL: https://github.com/apache/flink/pull/13641#discussion_r514120224
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexCancelTest.java
##########
@@ -244,104 +250,6 @@ public void testSendCancelAndReceiveFail() throws
Exception {
assertEquals(vertices.length - 1,
exec.getVertex().getExecutionGraph().getRegisteredExecutions().size());
}
- //
--------------------------------------------------------------------------------------------
- // Actions after a vertex has been canceled or while canceling
- //
--------------------------------------------------------------------------------------------
-
- @Test
- public void testScheduleOrDeployAfterCancel() {
- try {
- final ExecutionVertex vertex = getExecutionVertex();
- setVertexState(vertex, ExecutionState.CANCELED);
-
- assertEquals(ExecutionState.CANCELED,
vertex.getExecutionState());
-
- // 1)
- // scheduling after being canceled should be tolerated
(no exception) because
- // it can occur as the result of races
- {
- vertex.scheduleForExecution(
- TestingSlotProviderStrategy.from(new
ProgrammedSlotProvider(1)),
- LocationPreferenceConstraint.ALL,
- Collections.emptySet());
-
- assertEquals(ExecutionState.CANCELED,
vertex.getExecutionState());
- }
-
- // 2)
- // deploying after canceling from CREATED needs to
raise an exception, because
- // the scheduler (or any caller) needs to know that the
slot should be released
- try {
-
- final LogicalSlot slot = new
TestingLogicalSlotBuilder().createTestingLogicalSlot();
-
- vertex.deployToSlot(slot);
- fail("Method should throw an exception");
- }
- catch (IllegalStateException e) {
- assertEquals(ExecutionState.CANCELED,
vertex.getExecutionState());
- }
- }
- catch (Exception e) {
- e.printStackTrace();
- fail(e.getMessage());
- }
- }
-
- @Test
- public void testActionsWhileCancelling() {
Review comment:
superseded by
`DefaultSchedulerTest#skipDeploymentIfVertexVersionOutdated()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
