SteNicholas commented on pull request #13813: URL: https://github.com/apache/flink/pull/13813#issuecomment-718676236
> Thanks for taking a look at this. > > The feature code is fine, but I think the tests need some improvements. > > * This misses adding a V2 config snapshot to the test resources and ensuring we can resume from there. > * The test for large schema re-engineers the V2 method in the tests. > > * This is not necessary. We don't care whether the previous version fails, we only want the new version to succeed > * Rebuilding functionality in tests and testing that does not help tp guard anything in the production code, so it is ineffective. @StephanEwen , thanks for your detailed review. I have followed up your comments about the improvements of tests. Please review again if you are available. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
