XComp commented on pull request #13747: URL: https://github.com/apache/flink/pull/13747#issuecomment-718811927
@tillrohrmann I tested whether the memory configuration pops up when accessing `job-managers/config` manually for: * local standalone cluster (using `./bin/jobmanager.sh` through `./bin/start-cluster.sh`) * Kubernetes Session Cluster (using `./bin/kubernetes-session.sh # ...`) * Kubernetes Job Cluster (using `./bin/flink run-application -p 8 -t kubernetes-application # ...`) * Yarn Session Cluster (using `./bin/yarn-session.sh -jm 1024m -tm 4096`) * Yarn Job Cluster (using `./bin/flink run -m yarn-cluster -p 4 # ...`) Additionally, I verified the parameters passing for `./bin/mesos-appmaster.sh` and `./bin/mesos-appmaster-job.sh` which both execute `./bin/mesos-jobmanager.sh`. I also did a code review of passing the configuration trough `MesosJobClusterEntrypoint` and `MesosSessionClusterEntrypoint` to `LaunchableMesosWorker`. All looks good. So, I guess, the code is ready to get another review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
