sundargates commented on a change in pull request #13784:
URL: https://github.com/apache/flink/pull/13784#discussion_r514576347
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReader.java
##########
@@ -58,7 +60,7 @@
*
* @return the state of the source.
*/
- List<SplitT> snapshotState();
+ List<SplitT> snapshotState(long checkpointId);
Review comment:
Would it make sense to retain the old method too and add a default
implementation for the new method so that it doesn't
a. break existing users
b. if users didn't care about persisting any state related to the
checkpoint, then they don't have to implement this method?
```
List<SplitT> snapshotState();
default List<SplitT> snapshotState(long checkpointId) {
return snapshotState();
}
```
This would also be consistent with the way the enumerators/readers implement
the checkpointlistener API optionally to be notified on checkpoint related
events IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
