zhuzhurk commented on a change in pull request #13766:
URL: https://github.com/apache/flink/pull/13766#discussion_r514957052
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerNG.java
##########
@@ -84,7 +85,11 @@
void handleGlobalFailure(Throwable cause);
- boolean updateTaskExecutionState(TaskExecutionState taskExecutionState);
+ default boolean updateTaskExecutionState(TaskExecutionState
taskExecutionState) {
+ return
updateTaskExecutionState(TaskExecutionStateWrapper.createFrom(taskExecutionState));
Review comment:
You are right. However, this method will be removed soon when removing
the legacy scheduling in ExecutionGraph (FLINK-15626). And I hope to not
refactor its usages right now to avoid massive conflicts with the ongoing
change of FLINK-17760 which will replace the usage with
`SchedulerNG#updateTaskExecutionState()`.
I will mark it as deprecated for now to prevent it from being further used?
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
