[
https://issues.apache.org/jira/browse/FLINK-19853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224544#comment-17224544
]
Andrey Zagrebin commented on FLINK-19853:
-----------------------------------------
I think the test is unstable because we wait for all slots allocation future
(combined). If the pending slot allocation fails firstly then it probably fails
immediately the combined future but another allocated slot may be still being
released next in SlotPoolImpl.
Anyways, BulkSlotProviderImpl is dead code and the new
SlotSharingExecutionSlotAllocator works and is tested differently. We test
separately that the bulk timeout checker cancels the bulk w/o involving
SlotPoolImpl and that the bulk cancelation releases logical slots of
SharedSlot. Then we also test that SharedSlot releases the physical slot once
all logical slots are released.
I suggest we remove the dead code of BulkSlotProvider (FLINK-19923).
> BulkSlotProviderImplTest.testFailedBulkSlotAllocationReleasesAllocatedSlot
> failed in azure
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-19853
> URL: https://issues.apache.org/jira/browse/FLINK-19853
> Project: Flink
> Issue Type: Test
> Components: Runtime / Coordination
> Affects Versions: 1.12.0
> Reporter: Jingsong Lee
> Assignee: Andrey Zagrebin
> Priority: Critical
> Labels: test-stability
> Fix For: 1.12.0
>
>
> Instance:
> [https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_apis/build/builds/8486/logs/80]
> {code:java}
> 2020-10-28T10:08:41.3922048Z java.lang.AssertionError:
> 2020-10-28T10:08:41.3923050Z
> 2020-10-28T10:08:41.3923362Z Expected: a collection with size <0>
> 2020-10-28T10:08:41.3926321Z but: collection size was <1>
> 2020-10-28T10:08:41.3926732Z at
> org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> 2020-10-28T10:08:41.3927463Z at org.junit.Assert.assertThat(Assert.java:956)
> 2020-10-28T10:08:41.3928006Z at org.junit.Assert.assertThat(Assert.java:923)
> 2020-10-28T10:08:41.3928622Z at
> org.apache.flink.runtime.jobmaster.slotpool.BulkSlotProviderImplTest.testFailedBulkSlotAllocationReleasesAllocatedSlot(BulkSlotProviderImplTest.java:154)
> 2020-10-28T10:08:41.3929157Z at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2020-10-28T10:08:41.3929530Z at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2020-10-28T10:08:41.3929981Z at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
