[ 
https://issues.apache.org/jira/browse/FLINK-19927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224706#comment-17224706
 ] 

Chesnay Schepler commented on FLINK-19927:
------------------------------------------

There should definitely be a test that ensures that the EG issues notifications 
for all state transitions, but we first of course have to decide whether the 
new scheduler should even rely on this mechanism. EG#notifyExecutionChange is a 
no-op outside of legacy scheduling, so my assumption was that the new scheduler 
would handle this in some other form.

In the reconcilation test we should add a case to ensure that the tracker is 
properly cleared when the job is suspended or, more generally, if the job 
terminates.

> ExecutionStateUpdateListener is only updated when legacy scheduling is enabled
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-19927
>                 URL: https://issues.apache.org/jira/browse/FLINK-19927
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.12.0
>            Reporter: Robert Metzger
>            Assignee: Andrey Zagrebin
>            Priority: Blocker
>             Fix For: 1.12.0
>
>
> This is a finding from FLINK-19805.
> The {{ExecutionDeploymentTracker}} is never notified about executions 
> reaching terminal state, when using the default scheduler.
> This can potentially lead to invalid execution reconciliation behavior.
> Fixing this ticket probably involves switching the statements here: 
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1688-L1692
> As part of the this tickets resolution, I suggest to also introduce a test 
> case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to