zentol commented on a change in pull request #13829:
URL: https://github.com/apache/flink/pull/13829#discussion_r516177525
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -200,10 +200,12 @@ public void suspend() {
LOG.info("Suspending the slot manager.");
resourceTracker.clear();
- taskExecutorManager.close();
+ if (taskExecutorManager != null) {
Review comment:
IIRC you suggested the same thing during the original review; my
argument back then was that it would create a lot of unnecessary warnings.
I'm not sure what the better option is; but I suppose having any warning,
even if they are maybe unnecessary, is better than none?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
