AHeise commented on a change in pull request #13866:
URL: https://github.com/apache/flink/pull/13866#discussion_r515817110
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -502,9 +502,9 @@ protected void beforeInvoke() throws Exception {
// both the following operations are protected by the
lock
// so that we avoid race conditions in the case that
initializeState()
// registers a timer, that fires before the open() is
called.
-
operatorChain.initializeStateAndOpenOperators(createStreamTaskStateInitializer());
Review comment:
Good catch. I was wondering if there is any downside to putting data
into buffers before initializing state. Could it be that buffers are processed
before state is initialized?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -502,9 +502,9 @@ protected void beforeInvoke() throws Exception {
// both the following operations are protected by the
lock
Review comment:
Could you please fix commit msg and PR title ("before")?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
