[ 
https://issues.apache.org/jira/browse/FLINK-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171750#comment-15171750
 ] 

ASF GitHub Bot commented on FLINK-3333:
---------------------------------------

Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/1721#issuecomment-190159900
  
    By the way, I think that the change of the input rules about the 
non-iterator UDFs will actually allow us to simplify some code: all those 
drivers that work with such UDFs that get input objects through parameters, can 
be changed to always do object reuse, even when object reuse is turned off. 
This is made possible by the "Note: Objects may be modified after the method 
call is left. Therefore, it is not safe to remember objects across function 
calls." part in the "Reading input objects" field. This should improve 
performance in the object reuse disabled case.


> Documentation about object reuse should be improved
> ---------------------------------------------------
>
>                 Key: FLINK-3333
>                 URL: https://issues.apache.org/jira/browse/FLINK-3333
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.0.0
>            Reporter: Gabor Gevay
>            Assignee: Gabor Gevay
>            Priority: Critical
>             Fix For: 1.0.0
>
>
> The documentation about object reuse \[1\] has several problems, see \[2\].
> \[1\] 
> https://ci.apache.org/projects/flink/flink-docs-master/apis/batch/index.html#object-reuse-behavior
> \[2\] 
> https://docs.google.com/document/d/1cgkuttvmj4jUonG7E2RdFVjKlfQDm_hE6gvFcgAfzXg/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to