kl0u opened a new pull request #13911:
URL: https://github.com/apache/flink/pull/13911


   ## What is the purpose of the change
   
   Currently when executing an application in Attached Application mode
       we do not shutdown the cluster when the job is cancelled. That is
       because the exception thrown does not include the STATUS with which
       the job failed, so we cannot distinguish between different reasons
       of unsuccessful termination. This commit fixes this.
   
   ## Brief change log
   
   The `EmbeddedJobClient.getJobExecutionResult()` now throws the same 
exception as the execution in detached mode. This includes the usual exception 
thrown by the `jobResult.toJobExecutionResult(classLoader)` wrapped into an 
`UnsuccessfulTerminationException` which also includes the `ApplicationStatus`.
   
   ## Verifying this change
   
   Test was added in the `ApplicationDispatcherBootstrapTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to