zhuxiaoshang commented on a change in pull request #13902:
URL: https://github.com/apache/flink/pull/13902#discussion_r517073954
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSink.java
##########
@@ -145,7 +150,17 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
final FlinkKafkaProducer<RowData> kafkaProducer =
createKafkaProducer(keySerialization,
valueSerialization);
- return SinkFunctionProvider.of(kafkaProducer);
+ return new SinkFunctionProvider() {
Review comment:
yes,it's better to have common function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
