JingsongLi commented on a change in pull request #13729:
URL: https://github.com/apache/flink/pull/13729#discussion_r517173050
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FilesystemLookupFunction.java
##########
@@ -187,11 +169,34 @@ private void checkCacheReload() {
}
}
- private Row extractKey(RowData row) {
- Row key = new Row(lookupCols.length);
+ private RowData extractLookupKey(RowData row) {
+ GenericRowData key = new GenericRowData(lookupCols.length);
for (int i = 0; i < lookupCols.length; i++) {
- key.setField(i, converters[i].toExternal(row,
lookupCols[i]));
+ key.setField(i,
lookupFieldGetters[i].getFieldOrNull(row));
}
return key;
}
+
+ @Override
+ public void close() throws Exception {
+ if (this.partitionFetcher != null) {
Review comment:
`partitionFetcher` never null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
