AHeise commented on a change in pull request #13735:
URL: https://github.com/apache/flink/pull/13735#discussion_r517176519
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/partitioner/GlobalPartitioner.java
##########
@@ -40,6 +41,16 @@ public int
selectChannel(SerializationDelegate<StreamRecord<T>> record) {
return this;
}
+ @Override
+ public ChannelStateRescaler getUpstreamChannelStateRescaler() {
+ return ChannelStateRescaler.FIRST_CHANNEL;
+ }
+
+ @Override
+ public ChannelStateRescaler getDownstreamChannelStateRescaler() {
+ return ChannelStateRescaler.ROUND_ROBIN;
Review comment:
Yes changed that (see comment below). On upstream it should be almost
always round robin (broadcasting partitioner is the only exception where we
drop extra state).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
