rmetzger commented on a change in pull request #13796:
URL: https://github.com/apache/flink/pull/13796#discussion_r517177573
##########
File path: flink-connectors/flink-sql-connector-hbase-1.4/pom.xml
##########
@@ -87,6 +87,7 @@ under the License.
<exclude>org.apache.hbase:hbase-metrics*</exclude>
<exclude>org.apache.hbase:hbase-server*</exclude>
<exclude>org.apache.hbase:hbase-hadoop*-compat</exclude>
+
<exclude>org.apache.hbase:hbase-common:jar:tests</exclude>
Review comment:
This is the dependency tree:
```
[INFO] org.apache.flink:flink-sql-connector-hbase-1.4_2.11:jar:1.12-SNAPSHOT
[INFO] +-
org.apache.flink:flink-connector-hbase-1.4_2.11:jar:1.12-SNAPSHOT:compile
[INFO] | \-
org.apache.flink:flink-connector-hbase-base_2.11:jar:1.12-SNAPSHOT:compile
[INFO] | +- org.apache.hbase:hbase-server:jar:1.4.3:compile
[INFO] | | +- org.apache.hbase:hbase-common:jar:1.4.3:compile
[INFO] | | | +- org.apache.avro:avro:jar:1.10.0:compile
[INFO] | | | | +-
com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile
[INFO] | | | | \-
com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile
[INFO] | | | | \-
com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile
[INFO] | | | \-
com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
[INFO] | | +- org.apache.hbase:hbase-protocol:jar:1.4.3:compile
[INFO] | | +- org.apache.hbase:hbase-procedure:jar:1.4.3:compile
[INFO] | | | \- org.apache.hbase:hbase-common:jar:tests:1.4.3:compile
```
I can not add an exclude on hbase-server, because I can not exclude based on
the `tests` classifier.
The other question is: why are we depending on `hbase-server`. It would
probably be fine to depend on `hbase-common` and `hbase-client` (just judging
from the names). I quickly tried that, but it lead to all kinds of problems
with the tests.
How about working with the shade exclude for now, but filing a ticket, to
solve this properly in the next release cycle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
