godfreyhe commented on a change in pull request #13916:
URL: https://github.com/apache/flink/pull/13916#discussion_r517297719
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/processors/utils/TopologyGraph.java
##########
@@ -139,6 +139,18 @@ void unlink(ExecNode<?, ?> from, ExecNode<?, ?> to) {
return result;
}
+ /**
+ * Make the distance of node A at least as far as node Bby adding all
inputs of node B to node A.
Review comment:
Bby -> B by
by adding edge from all inputs of node B to node A.
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/plan/processors/utils/TopologyGraphTest.java
##########
@@ -157,4 +157,16 @@ public void testBoundedCalculateMaximumDistance() {
Assert.assertEquals(2, result.get(nodes[5]).intValue());
Assert.assertEquals(2, result.get(nodes[7]).intValue());
}
+
+ @Test
+ public void testAsFarAs() {
Review comment:
testMakeAsFarAs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
