[
https://issues.apache.org/jira/browse/FLINK-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172113#comment-15172113
]
ASF GitHub Bot commented on FLINK-3536:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1739
[FLINK-3536] Make clearer distinction between event time and processi…
…ng time
This brings it more in line with *ProcessingTimeWindows and makes it
clear what type of window assigner it is.
The old name, i.e. SlidingTimeWindows and TumblingTimeWindows is still
available but deprecated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-assigner-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1739
----
commit 73570e7b7bc43b1a6b04fac295ed68f3a9d68962
Author: Aljoscha Krettek <[email protected]>
Date: 2016-02-29T13:56:29Z
[FLINK-3536] Make clearer distinction between event time and processing time
This brings it more in line with *ProcessingTimeWindows and makes it
clear what type of window assigner it is.
The old name, i.e. SlidingTimeWindows and TumblingTimeWindows is still
available but deprecated.
----
> Make clearer distinction between event time and processing time
> ---------------------------------------------------------------
>
> Key: FLINK-3536
> URL: https://issues.apache.org/jira/browse/FLINK-3536
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Till Rohrmann
> Assignee: Aljoscha Krettek
> Priority: Minor
>
> If you define your own windows it is easy to mix up the time characteristic
> with the wrong set of predefined {{WindowAssigners}}. You cannot use
> processing time with a {{TumblingTimeWindows}} window assigner, for example.
> Neither from the name of {{TumblingTimeWindows}} nor from the JavaDocs it is
> clearly obvious that this {{WindowAssigner}} can only be used with event
> time. I think it would be better to rename the event time window assigner to
> something like {{TumblingEventTimeWindows}}. Additionally, we could extend
> the JavaDocs a bit, since not everyone knows that "based on the timestamps"
> means based on event time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
