[ 
https://issues.apache.org/jira/browse/FLINK-19984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicholas Jiang updated FLINK-19984:
-----------------------------------
    Description: Currently we have TypeInfoTestCoverageTest which checks that 
we have a test that extends TypeInformationTestBase for all type infos. But 
TypeSerializer doesn’t have the same thing that would verify that 
TypeSerializer has tests that extend SerializerTestBase and 
TypeSerializerUpgradeTestBase. Therefore we don’t know if test coverage of 
TypeSerializer is good. This would add TypeSerializerTestCoverageTest to check 
whether to have tests based on SerializerTestBase and 
TypeSerializerUpgradeTestBase because all serializers should have tests based 
on both of them.  (was: Currently we have TypeInfoTestCoverageTest which checks 
that we have a test that extends TypeInformationTestBase for all type infos. 
But we don’t have the same thing for TypeSerializer that would verify that we 
have tests that extend SerializerTestBase and TypeSerializerUpgradeTestBase. 
Therefore we don’t know if test coverage is good. This would add 
TypeSerializerTestCoverageTest to check whether to have tests based on 
SerializerTestBase and TypeSerializerUpgradeTestBase because all serializers 
should have tests based on both of them.)

> Add TypeSerializerTestCoverageTest to check whether tests based on 
> SerializerTestBase and TypeSerializerUpgradeTestBase
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-19984
>                 URL: https://issues.apache.org/jira/browse/FLINK-19984
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Core
>    Affects Versions: 1.12.0
>            Reporter: Nicholas Jiang
>            Priority: Minor
>
> Currently we have TypeInfoTestCoverageTest which checks that we have a test 
> that extends TypeInformationTestBase for all type infos. But TypeSerializer 
> doesn’t have the same thing that would verify that TypeSerializer has tests 
> that extend SerializerTestBase and TypeSerializerUpgradeTestBase. Therefore 
> we don’t know if test coverage of TypeSerializer is good. This would add 
> TypeSerializerTestCoverageTest to check whether to have tests based on 
> SerializerTestBase and TypeSerializerUpgradeTestBase because all serializers 
> should have tests based on both of them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to