TsReaper commented on a change in pull request #13860:
URL: https://github.com/apache/flink/pull/13860#discussion_r517768602
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java
##########
@@ -100,11 +100,10 @@
.defaultValue(false)
.withDescription("Enables join reorder in optimizer.
Default is disabled.");
- @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ @Documentation.TableOption(execMode = Documentation.ExecMode.BATCH)
public static final ConfigOption<Boolean>
TABLE_OPTIMIZER_MULTIPLE_INPUT_ENABLED =
key("table.optimizer.multiple-input-enabled")
- .defaultValue(false)
- .withDescription("Enables creating multiple input
operators to reduce shuffling. " +
- "Default is disabled as currently its physical
operators are not implemented. " +
- "This option is currently only used for plan
test cases.");
+ .defaultValue(true)
+ .withDescription("When it is true, the optimizer will
merge the operators with pipeline shuffling " +
Review comment:
"with pipeline shuffling" -> "with pipelined shuffling"
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.scala
##########
@@ -40,8 +40,6 @@ class MultipleInputCreationTest extends TableTestBase {
util.addTableSource[(Int, Long, String, Int)]("y", 'd, 'e, 'f, 'ny)
util.addTableSource[(Int, Long, String, Int)]("z", 'g, 'h, 'i, 'nz)
util.addDataStream[(Int, Long, String)]("t", 'a, 'b, 'c)
- util.tableConfig.getConfiguration.setBoolean(
- OptimizerConfigOptions.TABLE_OPTIMIZER_MULTIPLE_INPUT_ENABLED, true)
Review comment:
Keep this to emphasize that we're testing on multiple input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
