godfreyhe opened a new pull request #13931: URL: https://github.com/apache/flink/pull/13931
## What is the purpose of the change *after Calcite upgraded to 1.26, `a IN (1, 2) AND a = 1` can't be simplified to `a = 1`. [CALCITE-4364](https://issues.apache.org/jira/browse/CALCITE-4364) will fix this. But CALCITE-4364 will be in 1.27. One approach is we introduce a utility method to fix this, but many Calcite rules use RexSimplify to simplify expressions. The utility method will simplify the above expression, but RexSimplify will revert the optimization. So it's better we introduce RexSimplify add our fix into RexSimplify. This is a temporary solution, once upgrade to Calcite 1.27, RexSimplify should be removed.* ## Brief change log - *Introduce RexSimplify to simplify SEARCH conditions* ## Verifying this change This change added tests and can be verified as follows: - *Extended FlinkRexUtilTest to verify the change* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
