JingsongLi commented on pull request #13724:
URL: https://github.com/apache/flink/pull/13724#issuecomment-722180598


   > Thanks @JingsongLi , I left some minor comments. Another suggestion is to 
make the naming convention consistent between parquet and orc. For example, the 
base bulk format class of orc is `AbstractOrcFileInputFormat`, while the 
counterpart in parquet is named `ParquetVectorizedInputFormat`. Making them 
consistent should make the code easier to understand.
   
   I think it is better to add `abstract` to abstract class, but the name of 
`ParquetVectorizedInputFormat` is too long.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to