curcur commented on a change in pull request #13880:
URL: https://github.com/apache/flink/pull/13880#discussion_r517876455
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -717,6 +717,11 @@ private static boolean
isPointwisePartitioner(StreamPartitioner<?> partitioner)
}
private ResultPartitionType
determineResultPartitionType(StreamPartitioner<?> partitioner) {
+
+ if
(streamGraph.getCheckpointConfig().isApproximateLocalRecoveryEnabled()) {
+ return ResultPartitionType.PIPELINED_APPROXIMATE;
+ }
Review comment:
I've integrated "isApproximateLocalRecoveryEnabled" with
GlobalDataExchangeMode in the updated PR in this way:
- GlobalDataExchangeMode is decided based on whether
"isApproximateLocalRecoveryEnabled";
- Compatibility with ApproximateLocalRecoveryEnabled is also checked here
(unaligned checkpoint can not be used together with approximate local recovery
for now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
