curcur commented on a change in pull request #13880: URL: https://github.com/apache/flink/pull/13880#discussion_r518062621
########## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ApproximateLocalRecoveryDownstreamITCase.java ########## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.test.checkpointing; + +import org.apache.flink.api.common.functions.RichMapFunction; +import org.apache.flink.api.common.restartstrategy.RestartStrategies; +import org.apache.flink.api.java.tuple.Tuple4; +import org.apache.flink.configuration.AkkaOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.HeartbeatManagerOptions; +import org.apache.flink.configuration.HighAvailabilityOptions; +import org.apache.flink.configuration.JobManagerOptions; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.runtime.state.KeyGroupRangeAssignment; +import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.RichSinkFunction; +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction; +import org.apache.flink.test.util.MiniClusterWithClientResource; +import org.apache.flink.test.util.SuccessException; + +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.Test; + +import java.util.BitSet; + +import static org.apache.flink.test.util.TestUtils.tryExecute; + +/** Use RemoteInputChannel. Only for Upstream Reconnection. **/ + +public class ApproximateLocalRecoveryDownstreamITCase { + private static MiniClusterWithClientResource cluster; + private static final int BUFFER_SIZE = 4096; + + @Before + public void setup() throws Exception { + Configuration config = new Configuration(); + config.setString(JobManagerOptions.SCHEDULING_STRATEGY, "legacy"); + config.setString(HighAvailabilityOptions.HA_MODE, RegionFailoverITCase.TestingHAFactory.class.getName()); + + config.set(TaskManagerOptions.MEMORY_SEGMENT_SIZE, MemorySize.parse(Integer.toString(BUFFER_SIZE))); + config.setLong(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT, 1000000L); + config.setString(AkkaOptions.ASK_TIMEOUT, "1 h"); + + cluster = new MiniClusterWithClientResource( + new MiniClusterResourceConfiguration.Builder() + .setConfiguration(config) + .setNumberTaskManagers(4) + .setNumberSlotsPerTaskManager(1) + .build()); + cluster.before(); + } + + @AfterClass + public static void shutDownExistingCluster() { + if (cluster != null) { + cluster.after(); + cluster = null; + } + } + + /** + * Test the following topology. + * <pre> + * (source1/1) -----> (map1/1) -----> (sink1/1) + * </pre> + * (map1/1) fails, (map1/1) and (sink1/1) restart + */ + @Test + public void localTaskFailureRecoveryThreeTasks() throws Exception { Review comment: The purpose is to make sure approximate failover works - end-2-end - the failed task can reconnect to upstream with the entire downstream tasks restarted - partial records are cleaned up correctly for long or short records But you are right, the current test case works with enableApproximateLocalRecovery(false) as well. I think I can have an easy fix for this by making sure sources are not restarted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
