zentol commented on a change in pull request #13948:
URL: https://github.com/apache/flink/pull/13948#discussion_r518103712



##########
File path: flink-end-to-end-tests/README.md
##########
@@ -43,8 +36,12 @@ What's more, starting from 1.8.0 release it's required to 
make sure that `HADOOP
 
 Kubernetes test (test_kubernetes_embedded_job.sh) assumes a running minikube 
cluster.
 
+
 ## Writing Tests
 
+As of November 2020, Flink has two broad types of end to end tests: Bash-based 
end to end tests, located in the `test-scripts/` directory and Java-based end 
to end tests, such as the `PrometheusReporterEndToEndITCase`. The community 
recommends writing new tests as Java tests, as we are planning to deprecate the 
bash-based tests in the long run.

Review comment:
       ```suggestion
   As of November 2020, Flink has two broad types of end to end tests: 
Bash-based end-to-end tests, located in the `test-scripts/` directory and 
Java-based end-to-end tests, such as the `PrometheusReporterEndToEndITCase`. 
The community recommends writing new tests as Java tests, as we are planning to 
deprecate the bash-based tests in the long run.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to