aljoscha commented on pull request #13813:
URL: https://github.com/apache/flink/pull/13813#issuecomment-722450412
I pushed some changes to your branch, I hope that's ok:
- I added one prerequisite commit that adds testing infra for testing past
serializer snapshots. I also created a snapshot with v2 before bumping the
version
- then the second commit (from @SteNicholas) just needs to do the changes
and the existing test verifies that we can still restore
- when we bump the version the next time we would again have to create a
snapshot before
Strictly speaking, we wouldn't have to test restoring from old versions here
because that's covered by `AvroSerializerUpgradeTest` but it's good to be extra
sure and `AvroSerializerUpgradeTest` is a bit coarse grained because we only
create new snapshots per Flink version and not every time we bump a serializer
snapshot version.
cc @StephanEwen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
